netdev - Re: [net-next PATCH v2 02/17] net: Combine GENEVE and VXLAN port notifiers into single functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 08:23:01 -0700
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	Jesse Gross <jesse@...nel.org>
Cc:	Alexander Duyck <aduyck@...antis.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
	Hannes Frederic Sowa <hannes@...hat.com>,
	Eugenia Emantayev <eugenia@...lanox.com>,
	Jiri Benc <jbenc@...hat.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Ariel Elior <ariel.elior@...gic.com>,
	Tom Herbert <tom@...bertland.com>,
	Michael Chan <michael.chan@...adcom.com>,
	Dept-GELinuxNICDev@...gic.com, David Miller <davem@...emloft.net>
Subject: Re: [net-next PATCH v2 02/17] net: Combine GENEVE and VXLAN port
 notifiers into single functions

On Wed, Jun 15, 2016 at 4:50 PM, Jesse Gross <jesse@...nel.org> wrote:
> On Wed, Jun 15, 2016 at 3:07 PM, Alexander Duyck <aduyck@...antis.com> wrote:
>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
>> index e5e33cd01082..d12ee3a92fb5 100644
>> --- a/drivers/net/geneve.c
>> +++ b/drivers/net/geneve.c
>>  static void geneve_notify_del_rx_port(struct geneve_sock *gs)
>>  {
>> -       struct net_device *dev;
>> -       struct sock *sk = gs->sock->sk;
>> -       struct net *net = sock_net(sk);
>> -       sa_family_t sa_family = geneve_get_sk_family(gs);
>> -       __be16 port = inet_sk(sk)->inet_sport;
>> -
>> -       rcu_read_lock();
>> -       for_each_netdev_rcu(net, dev) {
>> -               if (dev->netdev_ops->ndo_del_geneve_port)
>> -                       dev->netdev_ops->ndo_del_geneve_port(dev, sa_family,
>> -                                                            port);
>> -       }
>> -
>> -       rcu_read_unlock();
>> +       udp_tunnel_notify_add_rx_port(gs->sock, UDP_TUNNEL_TYPE_GENEVE);
>>  }
>
> Looks like a typo here - calling add instead of delete.

Yeah.  I had a few other spots that occurred.  I thought I had caught
them all before submitting but I guess not.  I will fix that for v3.

Thanks.

- Alex