netdev - Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160615.214142.1092705919839921659.davem@davemloft.net>
Date:	Wed, 15 Jun 2016 21:41:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	timur@...eaurora.org
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org,
	shankerd@...eaurora.org, vikrams@...eaurora.org,
	cov@...eaurora.org, gavidov@...eaurora.org, robh+dt@...nel.org,
	andrew@...n.ch, bjorn.andersson@...aro.org, mlangsdo@...hat.com,
	jcm@...hat.com, agross@...eaurora.org, f.fainelli@...il.com
Subject: Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

From: Timur Tabi <timur@...eaurora.org>
Date: Tue, 14 Jun 2016 17:22:35 -0500

> +/* Free all descriptors of given receive queue */
> +static void emac_rx_q_free_descs(struct emac_adapter *adpt)
> +{
> +	struct emac_rx_queue *rx_q = &adpt->rx_q;
> +	struct device *dev = adpt->netdev->dev.parent;
> +	size_t size;
> +	int i;

Please always order local variable declarations from longest to shortest
line.

Audit your entire driver for this issue, thanks.