netdev - Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d122479b-f5cb-2dce-b0ba-d28f3254db32@cumulusnetworks.com>
Date:	Fri, 17 Jun 2016 14:15:38 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Stephen Hemminger <shemming@...cade.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	Daniel Borkmann <daniel@...earbox.net>, Phil Sutter <phil@....cc>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"julien.floret@...nd.com" <julien.floret@...nd.com>
Subject: Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On 6/17/16 12:57 PM, Stephen Hemminger wrote:
> On Fri, 17 Jun 2016 16:58:14 +0000
> Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:
>
>> Le 17/06/2016 18:46, Daniel Borkmann a écrit :
>>> On 06/17/2016 06:34 PM, Stephen Hemminger wrote:
>>>> On Fri, 17 Jun 2016 16:09:20 +0000
>>>> Daniel Borkmann <daniel@...earbox.net> wrote:
>>>>
>>>>> Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc
>>>>> (< 4.6)") ...
>>>>>
>>>>> Your changes effectively revert them again. Here, and some other parts of the
>>>>> bpf frontend
>>>>> code bits.
>>>>
>>>> GCC 4.6 is 3 years old. So perhaps it is time to move on.
>>>> Maybe add a GCC version check in the makefile, to fail cleanly.
>>>
>>> Well, you don't have to ask me but rather the patch submitters (Cc).
>>>
>>> I haven't used RHEL in quite a while, but I could imagine it might
>>> be related to built it there perhaps.
>> Yes. For some specific arch, we have only old toolchains.
>>
>> The rule was always to be backward compatible with old kernels. It implies to
>> also support the compilation with old toolchains ;-)
>
> It makes sense that if you can build a kernel with old toolchain, that
> iproute2 needs to be buildable as well.
>
> The current kernels are documented to require 3.2 or later.
>
>

Daniel's patch mentions anonymous structs so naming them should be fine.

Daniel: What OS were you using with the 4.6 gcc? I lost my range of OS 
VMs when I changed employers last year. At this point I don't recall 
which OS uses < 4.6.