netdev - Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41801a15-fd99-6916-211c-705b4445023d@cumulusnetworks.com>
Date:	Fri, 17 Jun 2016 14:47:51 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Daniel Borkmann <daniel@...earbox.net>,
	Stephen Hemminger <shemming@...cade.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	Phil Sutter <phil@....cc>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"julien.floret@...nd.com" <julien.floret@...nd.com>
Subject: Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On 6/17/16 2:36 PM, Daniel Borkmann wrote:
>
> Once again, you have to ask Nicolas or Julien for their RHEL version,
> not me ... please have a look at 8f80d450c3cb. ;)

I did, just ran right over the Author ;-)

>
> I just pointed to the fact that this would basically undo their changes
> that they've submitted some time ago to the BPF frontend, reintroducing
> the issue for them. Unfortunately, the anonymous struct cannot be named
> due to uapi reasons. It should have been named from the very beginning,
> but unfortunately too late now. So I would suggest to just leave those
> affected parts as is.

I was referring to Phil's patch. All of the struct {} req; 
initializations should be fine if you name the structs, but then need to 
run it through whatever compiler version the 6wind folks care about to 
verify that is true.