lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 16 Jun 2016 21:30:28 -0700
From:	Eric Dumazet <>
To:	Martin KaFai Lau <>
Cc:, Kernel Team <>,
	Chris Rapier <>,
	Eric Dumazet <>,
	Marcelo Ricardo Leitner <>,
	Neal Cardwell <>,
	Yuchung Cheng <>
Subject: Re: [PATCH net-next v6] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

On Mon, 2016-03-14 at 10:52 -0700, Martin KaFai Lau wrote:
> Per RFC4898, they count segments sent/received
> containing a positive length data segment (that includes
> retransmission segments carrying data).  Unlike
> tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments
> carrying no data (e.g. pure ack).
> The patch also updates the segs_in in tcp_fastopen_add_skb()
> so that segs_in >= data_segs_in property is kept.
> Together with retransmission data, tcpi_data_segs_out
> gives a better signal on the rxmit rate.
> v6: Rebase on the latest net-next
> v5: Eric pointed out that checking skb->len is still needed in
> tcp_fastopen_add_skb() because skb can carry a FIN without data.
> Hence, instead of open coding segs_in and data_segs_in, tcp_segs_in()
> helper is used.  Comment is added to the fastopen case to explain why
> segs_in has to be reset and tcp_segs_in() has to be called before
> __skb_pull().
> v4: Add comment to the changes in tcp_fastopen_add_skb()
> and also add remark on this case in the commit message.
> v3: Add const modifier to the skb parameter in tcp_segs_in()
> v2: Rework based on recent fix by Eric:
> commit a9d99ce28ed3 ("tcp: fix tcpi_segs_in after connection establishment")
> Signed-off-by: Martin KaFai Lau <>
> Cc: Chris Rapier <>
> Cc: Eric Dumazet <>
> Cc: Marcelo Ricardo Leitner <>
> Cc: Neal Cardwell <>
> Cc: Yuchung Cheng <>
> Acked-by: Eric Dumazet <>
> ---

Hi Martin

Have you sent the iproute2 ss corresponding patch ?

Thanks !

Powered by blists - more mailing lists