netdev - Re: [PATCH net-next] net, cls: also reject deleting all filters when TCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 22:51:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net, cls: also reject deleting all filters
 when TCA_KIND present

From: Daniel Borkmann <daniel@...earbox.net>
Date: Thu, 16 Jun 2016 23:19:29 +0200

> When we check for RTM_DELTFILTER, we should also reject the request
> for deleting all filters under a given parent when TCA_KIND attribute
> is present. If present, it's currently just ignored but there's also
> no point to let it pass in the first place either since this doesn't
> have any meaning with wild-card removal.
> 
> Fixes: ea7f8277f907 ("net, cls: allow for deleting all filters for given parent")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied, thanks Daniel.