netdev - Re: [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Jun 2016 12:32:00 +0100
From:	Måns Rullgård <mans@...sr.com>
To:	Philippe Reynes <tremyfr@...il.com>
Cc:	davem@...emloft.net, sf84@...oste.net, arnd@...db.de,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings

Philippe Reynes <tremyfr@...il.com> writes:

> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
>
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>

Acked-by: Mans Rullgard <mans@...sr.com>

> ---
>  drivers/net/ethernet/aurora/nb8800.c |   24 ++----------------------
>  1 files changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 4989d31..dc2c35d 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1035,26 +1035,6 @@ static const struct net_device_ops nb8800_netdev_ops = {
>  	.ndo_validate_addr	= eth_validate_addr,
>  };
>
> -static int nb8800_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> -{
> -	struct phy_device *phydev = dev->phydev;
> -
> -	if (!phydev)
> -		return -ENODEV;
> -
> -	return phy_ethtool_gset(phydev, cmd);
> -}
> -
> -static int nb8800_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> -{
> -	struct phy_device *phydev = dev->phydev;
> -
> -	if (!phydev)
> -		return -ENODEV;
> -
> -	return phy_ethtool_sset(phydev, cmd);
> -}
> -
>  static int nb8800_nway_reset(struct net_device *dev)
>  {
>  	struct phy_device *phydev = dev->phydev;
> @@ -1183,8 +1163,6 @@ static void nb8800_get_ethtool_stats(struct net_device *dev,
>  }
>
>  static const struct ethtool_ops nb8800_ethtool_ops = {
> -	.get_settings		= nb8800_get_settings,
> -	.set_settings		= nb8800_set_settings,
>  	.nway_reset		= nb8800_nway_reset,
>  	.get_link		= ethtool_op_get_link,
>  	.get_pauseparam		= nb8800_get_pauseparam,
> @@ -1192,6 +1170,8 @@ static const struct ethtool_ops nb8800_ethtool_ops = {
>  	.get_sset_count		= nb8800_get_sset_count,
>  	.get_strings		= nb8800_get_strings,
>  	.get_ethtool_stats	= nb8800_get_ethtool_stats,
> +	.get_link_ksettings	= phy_ethtool_get_link_ksettings,
> +	.set_link_ksettings	= phy_ethtool_set_link_ksettings,
>  };
>
>  static int nb8800_hw_init(struct net_device *dev)
> -- 
> 1.7.4.4
>

-- 
Måns Rullgård