netdev - Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57683AA6.7020302@codeaurora.org>
Date:	Mon, 20 Jun 2016 13:49:10 -0500
From:	Timur Tabi <timur@...eaurora.org>
To:	Rob Herring <robh@...nel.org>
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org,
	shankerd@...eaurora.org, vikrams@...eaurora.org,
	cov@...eaurora.org, gavidov@...eaurora.org, andrew@...n.ch,
	bjorn.andersson@...aro.org, mlangsdo@...hat.com, jcm@...hat.com,
	agross@...eaurora.org, davem@...emloft.net, f.fainelli@...il.com
Subject: Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

Rob Herring wrote:
>> >+		interrupt-parent = <&emac0>;
>> >+		#interrupt-cells = <1>;
>> >+		interrupts = <0 1>;
>> >+		interrupt-map-mask = <0xffffffff>;
>> >+		interrupt-map = <0 &intc 0 76 0
>> >+				 1 &intc 0 80 0>;
> Why? This looks unnecessary.

It may have made sense with an earlier version of the driver that had 
more complex interrupts.  I'll fix it in v6.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.