netdev - Re: [PATCH] ibmvnic: fix to use list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <576810C2.6080208@linux.vnet.ibm.com>
Date:	Mon, 20 Jun 2016 10:50:26 -0500
From:	Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
To:	weiyj_lk@....com, John Allen <jallen@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>
Cc:	netdev@...r.kernel.org,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete
 items

On 06/17/2016 09:53 PM, weiyj_lk@....com wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Since we will remove items off the list using list_del() we need
> to use a safe version of the list_for_each() macro aptly named
> list_for_each_safe().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/net/ethernet/ibm/ibmvnic.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 864cb21..0b6a922 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -3141,14 +3141,14 @@ static void handle_request_ras_comp_num_rsp(union ibmvnic_crq *crq,
>  
>  static void ibmvnic_free_inflight(struct ibmvnic_adapter *adapter)
>  {
> -	struct ibmvnic_inflight_cmd *inflight_cmd;
> +	struct ibmvnic_inflight_cmd *inflight_cmd, *tmp1;
>  	struct device *dev = &adapter->vdev->dev;
> -	struct ibmvnic_error_buff *error_buff;
> +	struct ibmvnic_error_buff *error_buff, *tmp2;
>  	unsigned long flags;
>  	unsigned long flags2;
>  
>  	spin_lock_irqsave(&adapter->inflight_lock, flags);
> -	list_for_each_entry(inflight_cmd, &adapter->inflight, list) {
> +	list_for_each_entry_safe(inflight_cmd, tmp1, &adapter->inflight, list) {
>  		switch (inflight_cmd->crq.generic.cmd) {
>  		case LOGIN:
>  			dma_unmap_single(dev, adapter->login_buf_token,
> @@ -3165,8 +3165,8 @@ static void ibmvnic_free_inflight(struct ibmvnic_adapter *adapter)
>  			break;
>  		case REQUEST_ERROR_INFO:
>  			spin_lock_irqsave(&adapter->error_list_lock, flags2);
> -			list_for_each_entry(error_buff, &adapter->errors,
> -					    list) {
> +			list_for_each_entry_safe(error_buff, tmp2,
> +						 &adapter->errors, list) {
>  				dma_unmap_single(dev, error_buff->dma,
>  						 error_buff->len,
>  						 DMA_FROM_DEVICE);
>
Thanks!

Acked-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...ts.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev