netdev - Re: [iproute PATCH 0/2] Check MAC address length when changing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160621085247.39fc11ba@xeon-e3>
Date:	Tue, 21 Jun 2016 08:52:47 -0700
From:	Stephen Hemminger <shemming@...cade.com>
To:	Phil Sutter <phil@....cc>
CC:	<netdev@...r.kernel.org>
Subject: Re: [iproute PATCH 0/2] Check MAC address length when changing it

On Thu, 16 Jun 2016 16:19:38 +0200
Phil Sutter <phil@....cc> wrote:

> Due to minimal checking in kernel space, MAC address setting was
> problematic in multiple ways:
> 
> - Setting an overly long MAC address was accepted and the extra parts
>   simply ignored.
> 
> - Setting an overly short MAC address for VFs was accepted and the
>   missing part filled with random garbage.
> 
> While patch 1 makes sure that in the second case above missing parts are
> padded with zero, patch 2 implements a real solution for both by
> comparing new and old address lengths prior to accepting the input. For
> VFs it is simply assumed that the length must match that of the PF's
> address.
> 
> Phil Sutter (2):
>   iplink: Add missing variable initialization
>   iplink: Check address length via netlink
> 
>  ip/iplink.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 51 insertions(+), 3 deletions(-)
> 

Sure. Applied