netdev - Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ab8380b-e9f1-7137-586c-9a4ab7f39da1@annapurnalabs.com>
Date:	Tue, 21 Jun 2016 13:02:24 +0300
From:	Netanel Belgazal <netanel@...apurnalabs.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	linux-kernel@...r.kernel.org, zorik@...apurnalabs.com,
	saeed@...apurnalabs.com, alex@...apurnalabs.com, msw@...zon.com,
	aligouri@...zon.com, antoine.tenart@...e-electrons.com
Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic
 Network Adapters (ENA)



On 06/21/2016 01:43 AM, Francois Romieu wrote:
> Netanel Belgazal <netanel@...apurnalabs.com> :
> [...]
>>> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h
>>> new file mode 100644
>>> index 0000000..e49ba43
>>> --- /dev/null
>>> [...]
>>> +static inline void ena_com_update_intr_reg(struct ena_eth_io_intr_reg *intr_reg,
>>> +					   u32 rx_delay_interval,
>>> +					   u32 tx_delay_interval,
>>> +					   bool unmask)
>>> +{
>>> +	intr_reg->intr_control = 0;
>>> +	intr_reg->intr_control |= rx_delay_interval &
>>> +		ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
>>> +
>>> +	intr_reg->intr_control |=
>>> +		(tx_delay_interval << ENA_ETH_IO_INTR_REG_TX_INTR_DELAY_SHIFT)
>>> +		& ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
>>>                                       ^^ TX ?
>>>
>>> Extra: you should not return NETDEV_TX_BUSY in the xmit handler while
>>> queueing is still enabled. Please drop packet and return NETDEV_TX_OK.
>> Ack.
>>
>> Thanks for your review.
> Ack/nack regarding use of ..._RX_INTR_DELAY_MASK with ..._TX_INTR_DELAY_SHIFT ?
You are right, it should have been TX_INTR_DELAY_SHIFT.
I'll fix that.