netdev - Re: [iproute PATCH v2 7/7] ip/tcp_metrics: Simplify process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160622125557.GB15980@orbyte.nwl.cc>
Date:	Wed, 22 Jun 2016 14:55:57 +0200
From:	Phil Sutter <phil@....cc>
To:	Jakub Sitnicki <jkbs@...hat.com>
Cc:	Stephen Hemminger <shemming@...cade.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	David Ahern <dsa@...ulusnetworks.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Julien Floret <julien.floret@...nd.com>, netdev@...r.kernel.org
Subject: Re: [iproute PATCH v2 7/7] ip/tcp_metrics: Simplify process_msg a bit

On Wed, Jun 22, 2016 at 01:34:13PM +0200, Jakub Sitnicki wrote:
> On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter <phil@....cc> wrote:
[...]
> > -	a = attrs[TCP_METRICS_ATTR_ADDR_IPV4];
> > -	if (a) {
> > +	if ((a = attrs[TCP_METRICS_ATTR_ADDR_IPV4])) {
> 
> Copy the pointer inside the branch?
> 
> Same gain on indentation while keeping checkpatch happy.

Good point! Thanks for the patch. :)

Cheers, Phil