netdev - Re: [PATCH] can: only call can_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04d27ce4-9393-764e-7e73-b1854a0136c3@pengutronix.de>
Date:	Wed, 22 Jun 2016 22:36:52 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Oliver Hartkopp <socketcan@...tkopp.net>,
	"David S. Miller" <davem@...emloft.net>,
	Alexander Aring <aar@...gutronix.de>,
	linux-can@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: only call can_stat_update with procfs

On 06/20/2016 05:51 PM, Arnd Bergmann wrote:
> The change to leave out procfs support in CAN when CONFIG_PROC_FS
> is not set was incomplete and leads to a build error:
> 
> net/built-in.o: In function `can_init':
> :(.init.text+0x9858): undefined reference to `can_stat_update'
> ERROR: "can_stat_update" [net/can/can.ko] undefined!
> 
> This tries a better approach, encapsulating all of the calls
> within IS_ENABLED(), so we also leave out the timer function
> from the object file.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: a20fadf85312 ("can: build proc support only if CONFIG_PROC_FS is activated")

Applied to can-next.

Tnx,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)