netdev - Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14311cf1-0b8e-cde2-54c0-c49a1b39b0c6@cumulusnetworks.com>
Date:	Thu, 23 Jun 2016 08:29:15 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:	"David S. Miller" <davem@...emloft.net>,
	Beniamino Galvani <bgalvani@...hat.com>
Subject: Re: [PATCH net v2] ipv6: enforce egress device match in per table
 nexthop lookups

On 6/23/16 8:20 AM, David Ahern wrote:
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>> index 969913d..520b788 100644
>> --- a/net/ipv6/route.c
>> +++ b/net/ipv6/route.c
>> @@ -1782,7 +1782,7 @@ static struct rt6_info
>> *ip6_nh_lookup_table(struct net *net,
>>      };
>>      struct fib6_table *table;
>>      struct rt6_info *rt;
>> -    int flags = 0;
>> +    int flags = RT6_LOOKUP_F_IFACE;
>>
>>      table = fib6_get_table(net, cfg->fc_table);
>>      if (!table)
>>
>
> Acked-by: David Ahern <dsa@...ulusnetworks.com>

I take that back.

I think RT6_LOOKUP_F_IFACE should only be set if cfg->fc_ifindex is set.