netdev - Re: [PATCH v10 07/22] IB/hns: Add event queue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2016 11:56:08 -0400
From:	Doug Ledford <dledford@...hat.com>
To:	Leon Romanovsky <leon@...nel.org>, Lijun Ou <oulijun@...wei.com>
Cc:	sean.hefty@...el.com, hal.rosenstock@...il.com,
	davem@...emloft.net, jeffrey.t.kirsher@...el.com,
	jiri@...lanox.com, ogerlitz@...lanox.com,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, gongyangming@...wei.com,
	xiaokun@...wei.com, tangchaofei@...wei.com, haifeng.wei@...wei.com,
	yisen.zhuang@...wei.com, yankejian@...wei.com,
	charles.chenxin@...wei.com, linuxarm@...wei.com
Subject: Re: [PATCH v10 07/22] IB/hns: Add event queue support

On 06/24/2016 11:46 AM, Leon Romanovsky wrote:
> On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote:

>>  /*************ROCEE_REG DEFINITION****************/
>>  #define ROCEE_VENDOR_ID_REG			0x0
>> @@ -44,8 +93,29 @@
>>  #define ROCEE_SYS_IMAGE_GUID_L_REG		0xC
>>  #define ROCEE_SYS_IMAGE_GUID_H_REG		0x10
>>  
>> +#define ROCEE_CAEP_AEQE_CONS_IDX_REG		0x3AC
>> +#define ROCEE_CAEP_CEQC_CONS_IDX_0_REG		0x3BC
>> +
>> +#define ROCEE_ECC_UCERR_ALM1_REG		0xB38
>> +#define ROCEE_ECC_UCERR_ALM2_REG		0xB3C
>> +#define ROCEE_ECC_CERR_ALM1_REG			0xB44
>> +#define ROCEE_ECC_CERR_ALM2_REG			0xB48
>> +
>>  #define ROCEE_ACK_DELAY_REG			0x14
>>  
>> +#define ROCEE_CAEP_CE_INTERVAL_CFG_REG		0x190
>> +#define ROCEE_CAEP_CE_BURST_NUM_CFG_REG		0x194
>> +
>>  #define ROCEE_MB1_REG				0x210
>>  
>> +#define ROCEE_CAEP_AEQC_AEQE_SHIFT_REG		0x3A0
>> +#define ROCEE_CAEP_CEQC_SHIFT_0_REG		0x3B0
>> +#define ROCEE_CAEP_CE_IRQ_MASK_0_REG		0x3C0
>> +#define ROCEE_CAEP_CEQ_ALM_OVF_0_REG		0x3C4
>> +#define ROCEE_CAEP_AE_MASK_REG			0x6C8
>> +#define ROCEE_CAEP_AE_ST_REG			0x6CC
>> +
>> +#define ROCEE_ECC_UCERR_ALM0_REG		0xB34
>> +#define ROCEE_ECC_CERR_ALM0_REG			0xB40
> 
> Indentation

I'm pretty sure this indentation is fine.  When looking at patch file
contents, the beginning of the line is shifted one char to the right, so
when using tabs for indents, if the line would normally end at the final
char before the next tab, and it gets shifted one char by the patch
format, the contents on the other side of the indent get jumped an extra
tab spot.  You would have to look at it as a file to know for sure, but
I'm betting you can ignore all of these indent issues.


-- 
Doug Ledford <dledford@...hat.com>
              GPG KeyID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)