netdev - Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160624.154608.48260039018744249.davem@davemloft.net>
Date:	Fri, 24 Jun 2016 15:46:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	qiang.zhao@....com
Cc:	oss@...error.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, xiaobo.xie@....com
Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

From: Qiang Zhao <qiang.zhao@....com>
Date: Fri, 24 Jun 2016 02:00:33 +0000

> On Thu, 2016-06-23 at 10:59PM, David Miller wrote:
>> -----Original Message-----
>> From: David Miller [mailto:davem@...emloft.net]
>> Sent: Thursday, June 23, 2016 10:59 PM
>> To: Qiang Zhao <qiang.zhao@....com>
>> Cc: oss@...error.net; linux-kernel@...r.kernel.org; netdev@...r.kernel.org;
>> Xiaobo Xie <xiaobo.xie@....com>
>> Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522
>> 
>> From: Zhao Qiang <qiang.zhao@....com>
>> Date: Thu, 23 Jun 2016 09:09:45 +0800
>> 
>> > +MODULE_DESCRIPTION(DRV_DESC);
>> 
>> There is no definition of DRV_DESC, so this makes it look like you didn't even
>> compile this driver.
> 
> I really, really compiled this driver.
> Thank you for your review and comments. I will modify it the next version.
> 
> [zhaoqiang@...an:~/upstream/linux]$ll drivers/net/wan/slic_ds26522.o
> -rw-r--r-- 1 zhaoqiang klocwork 153288 Jun 22 15:48 drivers/net/wan/slic_ds26522.o
> [zhaoqiang@...an:~/upstream/linux]$date

Obviously with the driver not configured as a module, and thus explicitly
not testing the failing statement at all.