netdev - Re: [PATCH] net: smc91x: ACPI Enable lan91x adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871t3k9uqe.fsf@belgarion.home>
Date:	Sun, 26 Jun 2016 11:15:21 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Jeremy Linton <jeremy.linton@....com>
Cc:	netdev@...r.kernel.org, nico@...xnic.net, davem@...emloft.net,
	fw@...len.de, felipe.balbi@...ux.intel.com, arnd@...db.de,
	ahs3@...hat.com
Subject: Re: [PATCH] net: smc91x: ACPI Enable lan91x adapters

Jeremy Linton <jeremy.linton@....com> writes:

> Enable lan91x adapters in some ARM machines and models
> when booted with an ACPI kernel.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Hi Jeremy,

I launched your change in my Jenkins yesterday (on Linus's mainline, not
linux-next), and I got:

CC      drivers/net/ethernet/smsc/smc91x.o
drivers/net/ethernet/smsc/smc91x.c:2488:23: error: 'smsc91x_acpi_match' undeclared here (not in a function)
   .acpi_match_table = smsc91x_acpi_match,

This platform build is _not_ for an device tree platform,
ie. CONFIG_OF=n. You'll have to move some around it seems.


Cheers.

--
Robert