netdev - Re: [PATCH] net: Fix resetting network_header in neigh_resolve_output and neigh_connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160627.101032.719251971537230839.davem@davemloft.net>
Date:	Mon, 27 Jun 2016 10:10:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ab@...hmed.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Fix resetting network_header in
 neigh_resolve_output and neigh_connected_output

From: Abdelrhman Ahmed <ab@...hmed.com>
Date: Thu, 23 Jun 2016 13:39:24 +0200

> neigh_resolve_output and neigh_connected_output resets the skb to network_header because of the retry loop and this reset will pull down the data pointer to the network header in the first iteration then hardware header will be added, but it will overwrite any data which is inserted between network header and hardware header (for example by netfilter hooks) only for the first packet(s) before using cached hardware header as neigh_hh_output (which is called for using cached hardware header) does not reset to the network header.

Please format your text properly into ~80 character long lines.