netdev - Potential double mutex_lock bug in net/ceph/auth.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAGbDTvo5zF_vO7KwG8frD7H0gf3fkJc_oTXiZ=tKbiD9GpPXmQ@mail.gmail.com>
Date:	Mon, 27 Jun 2016 10:22:22 +0200
From:	Iago Abal <iari@....dk>
To:	<netdev@...r.kernel.org>
CC:	Sage Weil <sage@...tank.com>, Alex Elder <elder@...tank.com>
Subject: Potential double mutex_lock bug in net/ceph/auth.c

Hi,

I'm testing a static bug finder (EBA) on Linux 4.7 release candidates
and I may have found a potential double lock:

  Double lock in net/ceph/auth.c
  second lock at 108: mutex_lock(& ac->mutex); [ceph_auth_build_hello]
  after calling from 263: ret = ceph_auth_build_hello(ac, msg_buf, msg_len);
  if ! ac->protocol -> true at 262
  first lock at 261: mutex_lock(& ac->mutex); [ceph_build_auth]

This seems to have been introduced by commit e9966076cdd9 ("libceph:
wrap auth methods in a mutex").

I hope it helps!

Thanks,

-- iago