netdev - Re: [PATCH net] net: avoid vlan ptype specific match to be leaked on real device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160627093736.GD2058@nanopsycho.orion>
Date:	Mon, 27 Jun 2016 11:37:36 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Paolo Abeni <pabeni@...hat.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	jiri@...lanox.com, aduyck@...antis.com, edumazet@...gle.com,
	daniel@...earbox.net
Subject: Re: [PATCH net] net: avoid vlan ptype specific match to be leaked on
 real device

Mon, Jun 27, 2016 at 11:28:32AM CEST, pabeni@...hat.com wrote:
>On Sun, 2016-06-26 at 16:06 -0400, David Miller wrote:
>> From: Jiri Pirko <jiri@...nulli.us>
>> Date: Wed, 22 Jun 2016 14:40:50 +0200
>> 
>> > The patch only unified the behaviour so everyone know what to expect
>> > regardless of the device type.
>> 
>> +1
>> 
>> And reverting this behavior back is going to hurt more people than it
>> will help, so I am not going to apply this, sorry.
>
>Would a /proc/net/vlan sysctl to control the switch from the new to the
>old behavior (with default to the new) make this acceptable ?

Ugh, please don't :(

>
>Recent users will not be affected, and users of the old behavior could
>manage kernel upgrade without breaking their applications. 
>
>Thank you,
>
>Paolo
>
>