netdev - Re: [PATCH net-next 6/6] r8152: add byte_enable for ocp_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d350382e-3798-f9c9-1639-45db15fceeca@cogentembedded.com>
Date:	Mon, 27 Jun 2016 13:57:22 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Hayes Wang <hayeswang@...ltek.com>, netdev@...r.kernel.org
Cc:	nic_swsd@...ltek.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word
 function

Hello.

On 6/27/2016 8:07 AM, Hayes Wang wrote:

> Add byte_enable for ocp_read_word() to replace reading 4 bytes data
> with reading the desired 2 bytes data.
>
> This is used to avoid the issue which is described in commit:b4d99def.

    scripts/checkpatch.pl now enforces certain commit citing style, yours 
doesn't match.

> The origin method always reads 4 bytes data, and it may have problem
> when reading the PHY regiters.

    Registers.

> The new method is supported since RTL8152B, but it doesn't influence
> the previous chips. The bits of the byte_enable for the previous chips
> are the reserved bits, and the hw would ignore them.
>
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>

[...]

MBR, Sergei