[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <08825943-ee97-c769-e70a-f6dcc3f49493@cumulusnetworks.com>
Date: Tue, 28 Jun 2016 11:40:40 -0600
From: David Ahern <dsa@...ulusnetworks.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH v2 iproute2 3/3] ss: Add support to filter on device
On 6/27/16 3:13 PM, Stephen Hemminger wrote:
> On Mon, 27 Jun 2016 11:34:25 -0700
> David Ahern <dsa@...ulusnetworks.com> wrote:
>
>> + case SSF_DEVCOND:
>> + {
>> + struct aafilter *a = (void *)f->pred;
>
> I don't like the wandering bracket left, but all the code has that.
> After this will change it to:
> case SSF_DEVCOND: {
> struct aafilter *a = f->pred;
> ...
>
meaning you'll take the patches as is since they follow current
formatting and you will apply a patch to fix the indentation in that
run_ssfilter? They have not shown up in your repo so want to make sure I
understand the intent.
Powered by blists - more mailing lists