netdev - Re: [PATCH] of_mdio: select fixed phy support unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160628.054342.1681185612913979373.davem@davemloft.net>
Date:	Tue, 28 Jun 2016 05:43:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	f.fainelli@...il.com, robh+dt@...nel.org, frowand.list@...il.com,
	david.daney@...ium.com, andrew@...n.ch,
	sergei.shtylyov@...entembedded.com, ben.hutchings@...ethink.co.uk,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] of_mdio: select fixed phy support unconditionally

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 24 Jun 2016 11:24:08 +0200

> Calling the fixed-phy functions when CONFIG_FIXED_PHY=m as a previous
> change tried cannot work if the caller is in built-in code:
> 
> drivers/of/built-in.o: In function `of_phy_register_fixed_link':
> of_reserved_mem.c:(.text+0x85e0): undefined reference to `fixed_phy_register'
> 
> Making of_mdio depend on 'FIXED_PHY || !FIXED_PHY' would solve this
> dependency by enforcing that OF_MDIO itself becomes a loadable module
> when FIXED_PHY=y, but that creates a different dependency as it
> breaks any built-in ethernet driver that uses of_mdio.
> 
> Making FIXED_PHY a bool option also cannot work, since it depends on
> PHYLIB, which again is tristate.
> 
> This version now uses 'select FIXED_PHY' to ensure that the fixed-phy
> portion of of_mdio is not optional. The main downside of this is
> a small increase in code size for cases that do not need fixed phy
> support, but it should avoid all of the link-time problems.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: d1bd330a229f ("of_mdio: Enable fixed PHY support if driver is a module")

Applied to net-next, thanks Arnd.

In the future, please be explicit about what tree a patch is
targetting by specifying it in your Subject line, as:

	[PATCH net-next] ...

or similar.

Thanks.