netdev - Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1467107935.2700.2.camel@ubuntu>
Date:	Tue, 28 Jun 2016 02:58:55 -0700
From:	Tien Hock Loh <thloh@...era.com>
To:	David Miller <davem@...emloft.net>
CC:	<robh+dt@...nel.org>, <mark.rutland@....com>,
	<peppe.cavallaro@...com>, <alexandre.torgue@...com>,
	<preid@...ctromag.com.au>, <dinguyen@...nsource.altera.com>,
	<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <thloh85@...il.com>,
	<cnphoon@...era.com>
Subject: Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to
 dwmac-socfpga

My fault, I wasn't testing against building as module, was always
building as part of the kernel. I'll get it fixed and put another patch
for review.

Thanks
Tien Hock

On Tue, 2016-06-28 at 05:48 -0400, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Tue, 28 Jun 2016 05:34:50 -0400 (EDT)
> 
> > From: <thloh@...era.com>
> > Date: Fri, 24 Jun 2016 02:13:23 -0700
> > 
> >> From: Tien Hock Loh <thloh@...era.com>
> >> 
> >> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> >> the dwmac is set to sgmii.
> >> 
> >> Signed-off-by: Tien Hock Loh <thloh@...era.com>
> >> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> >> Acked-by: Rob Herring <robh@...nel.org>
> > 
> > Applied to net-next, thanks.
> 
> I had to revert, this breaks the build:
> 
> ERROR: "tse_pcs_fix_mac_speed" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined!
> ERROR: "tse_pcs_init" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined!