netdev - Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jun 2016 16:10:56 -0400
From:	Jon Mason <jon.mason@...adcom.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Rafał Miłecki <zajec5@...il.com>,
	davem@...emloft.net, Florian Fainelli <f.fainelli@...il.com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

On Tue, Jun 28, 2016 at 3:43 PM, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote:
>> The bgmac_* print wrappers call dev_* prints with the dev pointer from
>> the bcma core.  In anticipation of removing the bcma requirement for
>> this driver, these must be changed to not reference that struct.  So,
>> simply change all of the bgmac_* prints to their dev_* counterparts.  In
>> some cases netdev_* prints are more appropriate, so change those as
>> well.
>
> Thanks, but...
>
>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> []
>> @@ -1515,7 +1516,7 @@ static void bgmac_get_drvinfo(struct net_device *net_dev,
>>                             struct ethtool_drvinfo *info)
>>  {
>>       strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
>> -     strlcpy(info->bus_info, "BCMA", sizeof(info->bus_info));
>> +     strlcpy(info->bus_info, "AXI", sizeof(info->bus_info));
>>  }
>
> Unrelated change?

This is a needed change, but unrelated to this patch.  I'll move it to
the 5/7 patch, where it more logically fits.

Thanks,
Jon

>