netdev - Re: [PATCH net-next 9/9] net: hns: get reset registers from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160629.051142.259737654994822294.davem@davemloft.net>
Date:	Wed, 29 Jun 2016 05:11:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Yisen.Zhuang@...wei.com
Cc:	salil.mehta@...wei.com, yankejian@...wei.com, liguozhu@...wei.com,
	huangdaode@...ilicon.com, arnd@...db.de,
	andriy.shevchenko@...ux.intel.com, andrew@...n.ch,
	geliangtang@....com, ivecera@...hat.com, fengguang.wu@...el.com,
	charles.chenxin@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linuxarm@...wei.com
Subject: Re: [PATCH net-next 9/9] net: hns: get reset registers from DT

From: Yisen Zhuang <Yisen.Zhuang@...wei.com>
Date: Mon, 27 Jun 2016 17:54:15 +0800

> @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus)
>  			return -ENODEV;
>  		}
>  
> +	sc_reg = &mdio_dev->sc_reg;
>  		/* 1. reset req, and read reset st check */
> -		ret = mdio_sc_cfg_reg_write(mdio_dev, MDIO_SC_RESET_REQ, 0x1,
> -					    MDIO_SC_RESET_ST, 0x1,
> +	ret = mdio_sc_cfg_reg_write(mdio_dev, sc_reg->mdio_reset_req, 0x1,
> +				    sc_reg->mdio_reset_st, 0x1,
>  					    MDIO_CHECK_SET_ST);
>  		if (ret) {
>  			dev_err(&bus->dev, "MDIO reset fail\n");

What in the world are you doing to the indentation here?

Please read your patches before actually sending them, such things
will be quite obvious by simple visual inspection.