netdev - Re: [PATCH net] tcp: do not send too big packets at retransmit time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160629.052617.632863831347001831.davem@davemloft.net>
Date:	Wed, 29 Jun 2016 05:26:17 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ncardwell@...gle.com, arjun@...lsio.com, edumazet@...gle.com,
	netdev@...r.kernel.org, hariprasad@...lsio.com, leedom@...lsio.com,
	kumaras@...lsio.com, santosh@...lsio.com, nirranjan@...lsio.com,
	ycheng@...gle.com
Subject: Re: [PATCH net] tcp: do not send too big packets at retransmit time

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 27 Jun 2016 17:38:50 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Arjun reported a bug in TCP stack and bisected it to a recent commit.
> 
> In case where we process SACK, we can coalesce multiple skbs
> into fat ones (tcp_shift_skb_data()), to lower write queue
> overhead, because we do not expect to retransmit these packets.
> 
> However, SACK reneging can happen, forcing the sender to retransmit
> all these packets. If skb->len is above 64KB, we then send buggy
> IP packets that could hang TSO engine on cxgb4.
> 
> Neal suggested to use tcp_tso_autosize() instead of tp->gso_segs
> so that we cook packets of optimal size vs TCP/pacing.
> 
> Thanks to Arjun for reporting the bug and running the tests !
> 
> Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Arjun V <arjun@...lsio.com>
> Tested-by: Arjun V <arjun@...lsio.com>

Applied.