netdev - Re: [patch] qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160629.054801.713412217544385924.davem@davemloft.net>
Date:	Wed, 29 Jun 2016 05:48:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	Dept-GELinuxNICDev@...gic.com, sony.chacko@...gic.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] qlcnic: use the correct ring in
 qlcnic_83xx_process_rcv_ring_diag()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Mon, 27 Jun 2016 23:50:29 +0300

> There is a static checker warning here "warn: mask and shift to zero"
> and the code sets "ring" to zero every time.  From looking at how
> QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the
> qlcnic_83xx_hndl() should be removed.
> 
> Fixes: 4be41e92f7c6 ('qlcnic: 83xx data path routines')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.