netdev - Re: [PATCH v10 07/22] IB/hns: Add event queue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160629104132.GA4750@leon.nu>
Date:	Wed, 29 Jun 2016 13:41:32 +0300
From:	Leon Romanovsky <leon@...nel.org>
To:	oulijun <oulijun@...wei.com>
Cc:	Doug Ledford <dledford@...hat.com>, sean.hefty@...el.com,
	hal.rosenstock@...il.com, davem@...emloft.net,
	jeffrey.t.kirsher@...el.com, jiri@...lanox.com,
	ogerlitz@...lanox.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	gongyangming@...wei.com, xiaokun@...wei.com,
	tangchaofei@...wei.com, haifeng.wei@...wei.com,
	yisen.zhuang@...wei.com, yankejian@...wei.com,
	charles.chenxin@...wei.com, linuxarm@...wei.com
Subject: Re: [PATCH v10 07/22] IB/hns: Add event queue support

On Wed, Jun 29, 2016 at 04:53:39PM +0800, oulijun wrote:

> >> +
> >> +	for (i = 0; i < npages; ++i)
> >> +		if (eq->buf_list[i].buf)
> > 
> > Is it possible situation to have eq->buf_list[i].buf == NULL at the
> > middle of iteration?
> > 
> We have analysized it according to your reivews. We think that the eq->buf_list[i].buf
> is not NULL at the middle of iteration because only the eq->buf_list[i].buf allocated
> when the hns_roce_free_eq be called. As result, the if (eq->buf_list[i].buf) condition
> should be deleted, right?

Yes, please.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)