netdev - Re: [PATCH net] bonding: prevent out of bound accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+Y=1T_iYGL83bL8pN2QtC8-jiiGXyG0qLmpeOE8R3WX5w@mail.gmail.com>
Date:	Thu, 30 Jun 2016 16:13:37 +0200
From:	Dmitry Vyukov <dvyukov@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Mahesh Bandewar <maheshb@...gle.com>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	Ding Tianhong <dingtianhong@...wei.com>
Subject: Re: [PATCH net] bonding: prevent out of bound accesses

On Thu, Jun 30, 2016 at 4:08 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2016-06-30 at 15:35 +0200, Dmitry Vyukov wrote:
>
>>
>> What does nm -S say?
>> I've tried to compile a sample program with gcc6 and
>> __attribute__((aligned(8))) does in fact force alignment of start of
>> the symbol, but size still stays 6. (and asan still barks on my test
>> program).
>
> Right, but then it means I also need to change mac_bcast[] and
> mac_v6_allmcast[] in bond_alb.c to avoid false positive.
>
> (Technically, if their alignment is 8, we have 8 bytes there,
> no way it could span 2 pages)

Agree.

> I'll send a v2.

Thanks!