netdev - Re: [Patch net] net_sched: fix mirrored packets checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXd7-rx_XzoZ=8gVekLD0YRLkmr0kgud3WoXnjEvCOLZw@mail.gmail.com>
Date:	Thu, 30 Jun 2016 16:41:17 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Tom Herbert <tom@...bertland.com>
Subject: Re: [Patch net] net_sched: fix mirrored packets checksum

On Thu, Jun 30, 2016 at 4:26 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Thu, Jun 30, 2016 at 4:11 PM, Daniel Borkmann <daniel@...earbox.net> wrote:
>> On 07/01/2016 12:42 AM, Cong Wang wrote:
>>>
>>> On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann <daniel@...earbox.net>
>>> wrote:
>>>>
>>>>
>>>> Maybe makes sense to move skb_push_rcsum() but /also/ skb_pull_rcsum()
>>>> to the header then? Both seem similarly small at least (could be split
>>>> f.e into two patches then, first for the move, second for the actual
>>>> fix).
>>>
>>>
>>> No objection from me. Please feel free to send a patch. ;)
>>
>>
>> Shrug, I actually meant this as feedback to your patch, since you move that
>> helper and not as a note to myself. ;)
>
> Interesting, my patch only moves what it needs, why does it need
> to do more?

In case you miss the context:
http://marc.info/?l=linux-netdev&m=146730654005424&w=2

This patch should be backported to stable too, which is another
reason why we should keep it as small as possible.

Here, at Twitter, we already backported it to 4.1 kernel for testing.

(The reason why I don't have a Fixes: tag is that I don't identify an
offending commit to blame yet.)