netdev - Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC3K-4pu2k8HZ3g-LxbVAFOxPayDT=hK1qgix1Pc81aTEmGQzA@mail.gmail.com>
Date:	Fri, 1 Jul 2016 10:29:36 -0400
From:	Jon Mason <jon.mason@...adcom.com>
To:	Rob Herring <robh@...nel.org>
Cc:	Rafał Miłecki <zajec5@...il.com>,
	davem@...emloft.net, Florian Fainelli <f.fainelli@...il.com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation
 for bgmac

On Thu, Jun 30, 2016 at 10:56 PM, Rob Herring <robh@...nel.org> wrote:
> On Thu, Jun 30, 2016 at 06:59:13PM -0400, Jon Mason wrote:
>> Signed-off-by: Jon Mason <jon.mason@...adcom.com>
>> ---
>>  .../devicetree/bindings/net/brcm,bgmac-nsp.txt     | 24 ++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-nsp.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,bgmac-nsp.txt b/Documentation/devicetree/bindings/net/brcm,bgmac-nsp.txt
>> new file mode 100644
>> index 0000000..022946c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/brcm,bgmac-nsp.txt
>> @@ -0,0 +1,24 @@
>> +Broadcom GMAC Ethernet Controller Device Tree Bindings
>> +-------------------------------------------------------------
>> +
>> +Required properties:
>> + - compatible:       "brcm,bgmac-nsp"
>
> Usually we do <soc>-<block> order.

Thanks, I'll make the necessary changes and push out a v2.

>
>> + - reg:              Address and length of the GMAC registers,
>> +             Address and length of the GMAC IDM registers
>> + - reg-names:        Names of the registers.  Must have both "gmac_base" and
>> +             "idm_base"
>> + - interrupts:       Interrupt number
>> +
>> +Optional properties:
>> +- mac-address:       See ethernet.txt file in the same directory
>> +
>> +Examples:
>> +
>> +gmac0: ethernet@...22000 {
>> +     compatible = "brcm,bgmac-nsp";
>> +     reg = <0x18022000 0x1000>,
>> +           <0x18110000 0x1000>;
>> +     reg-names = "gmac_base", "idm_base";
>> +     interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
>> +     status = "disabled";
>> +};
>> --
>> 1.9.1
>>