netdev - Re: [PATCH net] net: poll tx timeout only on active tx queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR11MB00889A8F46E66124C99E43DE97250@CO2PR11MB0088.namprd11.prod.outlook.com>
Date:	Fri, 1 Jul 2016 04:50:10 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Saeed Mahameed <saeedm@....mellanox.co.il>,
	Eric Dumazet <eric.dumazet@...il.com>
CC:	Saeed Mahameed <saeedm@...lanox.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"Tom Herbert" <tom@...bertland.com>,
	Mohamad Haj Yahia <mohamad@...lanox.com>
Subject: Re: [PATCH net] net: poll tx timeout only on active tx queues

> currently all the device driver call  netif_tx_start_all_queues(dev)
> on open to W/A this issue. which is strange since only
> real_num_tx_queues are active.

You could also argue that netif_tx_start_all_queues() should
only enable the real_num_tx_queues.
[Although that would obviously cause all drivers to reach the
'problem' you're currently fixing].