netdev - Re: [patch net-next 23/42] mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <070108fc-a6bd-b23e-8ada-ef82717a82ff@cumulusnetworks.com>
Date:	Fri, 1 Jul 2016 10:10:58 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, idosch@...lanox.com, yotamg@...lanox.com,
	eladr@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com,
	sfeldma@...il.com, roopa@...ulusnetworks.com, andy@...yhouse.net,
	tgraf@...g.ch, jhs@...atatu.com, linville@...driver.com,
	ivecera@...hat.com
Subject: Re: [patch net-next 23/42] mlxsw: spectrum_router: Implement fib4
 add/del switchdev obj ops

On 7/1/16 8:04 AM, Jiri Pirko wrote:

> +static int
> +mlxsw_sp_router_fib4_entry_init(struct mlxsw_sp *mlxsw_sp,
> +				const struct switchdev_obj_ipv4_fib *fib4,
> +				struct mlxsw_sp_fib_entry *fib_entry)
> +{
> +	struct fib_info *fi = fib4->fi;
> +
> +	if (fib4->type == RTN_LOCAL || fib4->type == RTN_BROADCAST) {
> +		fib_entry->type = MLXSW_SP_FIB_ENTRY_TYPE_TRAP;
> +		return 0;
> +	}
> +	if (fib4->type != RTN_UNICAST)
> +		return -EINVAL;

This is going to cause offload to fail b/c is a user has RTN_UNREACHABLE 
or RTN_PROHIBIT default route in a table. Those routes are needed per 
VRF/table to keep lookups from dropping to the another table.