netdev - Re: [PATCH 02/17] batman-adv: statically print gateway table header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467393566.21157.10.camel@perches.com>
Date:	Fri, 01 Jul 2016 10:19:26 -0700
From:	Joe Perches <joe@...ches.com>
To:	Simon Wunderlich <sw@...onwunderlich.de>, davem@...emloft.net
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
	Antonio Quartulli <a@...table.cc>,
	Marek Lindner <mareklindner@...mailbox.ch>
Subject: Re: [PATCH 02/17] batman-adv: statically print gateway table header

On Fri, 2016-07-01 at 15:08 +0200, Simon Wunderlich wrote:
> To make it easier to search through the code it is better to print static
> strings directly instead of using format strings printing constants.

It's also generally smaller object code and faster at runtime.

$ size net/batman-adv/gateway_client.o*
   text	   data	    bss	    dec	    hex	filename
   4898	      1	      0	   4899	   1323	net/batman-adv/gateway_client.o.new
   4951	      1	      0	   4952	   1358	net/batman-adv/gateway_client.o.old