netdev - Re: [PATCH] usbnet: add reset_resume quirk to prevent resume failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160701.155838.304989883410639353.davem@davemloft.net>
Date:	Fri, 01 Jul 2016 15:58:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vivek.bhagat@...sung.com
Cc:	netdev@...r.kernel.org, hemanshu.s@...sung.com,
	vikas.bansal@...sung.com
Subject: Re: [PATCH] usbnet: add reset_resume quirk to prevent resume
 failure

From: Vivek Kumar Bhagat <vivek.bhagat@...sung.com>
Date: Thu, 30 Jun 2016 10:41:59 +0000 (GMT)

> 
> Ideally, usbnet_resume is sufficient for device resume operation.
> since usbcore function usb_resume_device() sets udev->reset_resume
> flag as a quirk solution, reset_resume() quirk we can keep in
> class driver also. We checked on dongle DA-Queen UFE20C,
> without reset function resume operation fails. Reason could be
> some power glitch during suspend time due to which device lose
> its internal state and it needs a device phy reset again during
> resume to recover.
> 
> Signed-off-by: Vivek Kumar Bhagat <vivek.bhagat@...sung.com>
> Signed-off-by: Vikas Bansal <vikas.bansal@...sung.com>
> Signed-off-by: Sangmin Bae <sm79.bae@...sung.com>

You've seen this necessary for one device, yet you are doing this
new reset for all usbnet devices.

That doesn't sound correct or safe at all.

I'm not applying this, sorry.