lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1467536094-23722-1-git-send-email-vegard.nossum@oracle.com> Date: Sun, 3 Jul 2016 10:54:54 +0200 From: Vegard Nossum <vegard.nossum@...cle.com> To: santosh.shilimkar@...cle.com, davem@...emloft.net Cc: sowmini.varadhan@...cle.com, rds-devel@....oracle.com, linux-rdma@...r.kernel.org, netdev@...r.kernel.org Subject: [PATCH] RDS: fix rds_tcp_init() error path If register_pernet_subsys() fails, we shouldn't try to call unregister_pernet_subsys(). Fixes: 467fa15356 ("RDS-TCP: Support multiple RDS-TCP listen endpoints, one per netns.") Cc: stable@...r.kernel.org Cc: Sowmini Varadhan <sowmini.varadhan@...cle.com> Cc: David S. Miller <davem@...emloft.net> Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com> --- net/rds/tcp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/rds/tcp.c b/net/rds/tcp.c index 74ee126..c8a7b4c 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -616,7 +616,7 @@ static int rds_tcp_init(void) ret = rds_tcp_recv_init(); if (ret) - goto out_slab; + goto out_pernet; ret = rds_trans_register(&rds_tcp_transport); if (ret) @@ -628,8 +628,9 @@ static int rds_tcp_init(void) out_recv: rds_tcp_recv_exit(); -out_slab: +out_pernet: unregister_pernet_subsys(&rds_tcp_net_ops); +out_slab: kmem_cache_destroy(rds_tcp_conn_slab); out: return ret; -- 1.9.1
Powered by blists - more mailing lists