netdev - Re^2: [PATCH] usbnet: add reset_resume quirk to prevent resume failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 04 Jul 2016 04:14:11 +0000 (GMT)
From:	Vivek Kumar Bhagat <vivek.bhagat@...sung.com>
To:	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	HEMANSHU SRIVASTAVA <hemanshu.s@...sung.com>,
	Vikas Bansal <vikas.bansal@...sung.com>
Subject: Re^2: [PATCH] usbnet: add reset_resume quirk to prevent resume failure

Hello David,

Class driver .reset_resume() function will be called only when USB host driver has
set below flag, otherwise it will follow normal resume (without reset).
    if (udev->quirks & USB_QUIRK_RESET_RESUME)       <-- usb_resume_device()
            udev->reset_resume = 1;

I shall remove cdc_eem changes, then it would be applicable for asix 2.0 device only. 
I shall make one patch for asix 2.0 (asix_devices.c) and asix 3.0 (ax88179_178a.c).
We have verified on almost all type of available asix dongle.
I hope it would be okay.

Regards,
Vivek
------- Original Message -------
Sender : David Miller<davem@...emloft.net>
Date : Jul 02, 2016 01:28 (GMT+05:30)
Title : Re: [PATCH] usbnet: add reset_resume quirk to prevent resume failure

From: Vivek Kumar Bhagat 
Date: Thu, 30 Jun 2016 10:41:59 +0000 (GMT)

> 
> Ideally, usbnet_resume is sufficient for device resume operation.
> since usbcore function usb_resume_device() sets udev->reset_resume
> flag as a quirk solution, reset_resume() quirk we can keep in
> class driver also. We checked on dongle DA-Queen UFE20C,
> without reset function resume operation fails. Reason could be
> some power glitch during suspend time due to which device lose
> its internal state and it needs a device phy reset again during
> resume to recover.
> 
> Signed-off-by: Vivek Kumar Bhagat 
> Signed-off-by: Vikas Bansal 
> Signed-off-by: Sangmin Bae 

You've seen this necessary for one device, yet you are doing this
new reset for all usbnet devices.

That doesn't sound correct or safe at all.

I'm not applying this, sorry.