netdev - Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMp4zn-MNgqJ1Xzm8JO529=LVyB71bdYaUm0FqyNCMx4Hf+xSA@mail.gmail.com>
Date:	Tue, 5 Jul 2016 08:35:18 -0700
From:	Sargun Dhillon <sargun@...gun.me>
To:	netdev@...r.kernel.org
Subject: Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]

Does it make sense to backport
3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm
(4.4) release? I can trivially recreate the issue represented by
3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF filter
that clones an ingress ICMP packet, and then tries to set the
destination MAC address.

It seems like the patch applies cleanly to 4.4. I cherry-picked it,
and rebuilt my kernel, and at least in the trivial test case passes.