netdev - Re: [net-next PATCH] net: tracepoint napi:napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Jul 2016 11:55:44 -0700 (PDT)
From:	David Miller <davem@...hat.com>
To:	brouer@...hat.com
Cc:	netdev@...r.kernel.org, rostedt@...dmis.org
Subject: Re: [net-next PATCH] net: tracepoint napi:napi_poll add work and
 budget

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Tue, 05 Jul 2016 19:35:27 +0200

> Can this patch go thought the net-next tree?

Sure... when it actually compiles.

If you're changing a fundamental signature like this, it is in your
best interest to do an allmodconfig build... before I do.

net/core/drop_monitor.c: In function ‘set_all_monitor_traces’:
net/core/drop_monitor.c:241:34: warning: passing argument 1 of ‘register_trace_napi_poll’ from incompatible pointer type
   rc |= register_trace_napi_poll(trace_napi_poll_hit, NULL);
                                  ^
In file included from include/trace/events/skb.h:9:0,
                 from net/core/drop_monitor.c:31:
include/linux/tracepoint.h:199:2: note: expected ‘void (*)(void *, struct napi_struct *, int,  int)’ but argument is of type ‘void (*)(void *, struct napi_struct *)’
  register_trace_##name(void (*probe)(data_proto), void *data) \
  ^
include/linux/tracepoint.h:348:2: note: in expansion of macro ‘__DECLARE_TRACE’
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
  ^
include/linux/tracepoint.h:484:2: note: in expansion of macro ‘DECLARE_TRACE’
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^
include/trace/events/napi.h:13:1: note: in expansion of macro ‘TRACE_EVENT’
 TRACE_EVENT(napi_poll,
 ^
net/core/drop_monitor.c:246:36: warning: passing argument 1 of ‘unregister_trace_napi_poll’ from incompatible pointer type
   rc |= unregister_trace_napi_poll(trace_napi_poll_hit, NULL);
                                    ^
In file included from include/trace/events/skb.h:9:0,
                 from net/core/drop_monitor.c:31:
include/linux/tracepoint.h:212:2: note: expected ‘void (*)(void *, struct napi_struct *, int,  int)’ but argument is of type ‘void (*)(void *, struct napi_struct *)’
  unregister_trace_##name(void (*probe)(data_proto), void *data) \
  ^
include/linux/tracepoint.h:348:2: note: in expansion of macro ‘__DECLARE_TRACE’
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
  ^
include/linux/tracepoint.h:484:2: note: in expansion of macro ‘DECLARE_TRACE’
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^
include/trace/events/napi.h:13:1: note: in expansion of macro ‘TRACE_EVENT’
 TRACE_EVENT(napi_poll,
 ^
  C-c C-cscripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/cavium/liquidio' failed
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/cisco' failed
make[4]: *** [drivers/net/ethernet/cavium/liquidio] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/fddi' failed
make[2]: *** [drivers/net/fddi] Interrupt
make[3]: *** [drivers/net/ethernet/cisco] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/chelsio' failed
make[3]: *** [drivers/net/ethernet/chelsio] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet/cavium' failed
make[3]: *** [drivers/net/ethernet/cavium] Interrupt
scripts/Makefile.build:440: recipe for target 'net/wimax' failed
make[1]: *** [net/wimax] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/pci' failed
make[1]: *** [drivers/pci] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net/ethernet' failed
make[2]: *** [drivers/net/ethernet] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/media/usb/tm6000' failed
make[3]: *** [drivers/media/usb/tm6000] Interrupt
scripts/Makefile.build:295: recipe for target 'net/netfilter/xt_dscp.o' failed
make[2]: *** [net/netfilter/xt_dscp.o] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/net' failed
make[1]: *** [drivers/net] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/media/usb' failed
make[2]: *** [drivers/media/usb] Interrupt
scripts/Makefile.build:440: recipe for target 'drivers/media' failed
make[1]: *** [drivers/media] Interrupt
Makefile:987: recipe for target 'drivers' failed
make: *** [drivers] Interrupt
scripts/Makefile.build:440: recipe for target 'net/netfilter' failed
make[1]: *** [net/netfilter] Interrupt
Makefile:987: recipe for target 'net' failed
make: *** [net] Interrupt