netdev - Re: [PATCH net] bonding: fix enslavement slave link notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160705.121310.808927448900147837.davem@davemloft.net>
Date:	Tue, 05 Jul 2016 12:13:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	saeedm@...lanox.com
Cc:	netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
	gospo@...ulusnetworks.com, jiri@...lanox.com, avivh@...lanox.com
Subject: Re: [PATCH net] bonding: fix enslavement slave link notifications

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Tue,  5 Jul 2016 12:09:47 +0300

> From: Aviv Heller <avivh@...lanox.com>
> 
> Currently, link notifications are not sent by
> bond_set_slave_link_state() upon enslavement if
> the slave is enslaved when up.
> 
> This happens because slave->link default init value
> is 0, which is the same as BOND_LINK_UP, resulting
> in bond_set_slave_link_state() ignoring this transition.
> 
> This patch sets the default value of slave->link to
> BOND_LINK_NOCHANGE, assuring it will count as a state
> transition and thus trigger notification logic.
> 
> Signed-off-by: Aviv Heller <avivh@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

Applied.