netdev - Re: Problem: BUG_ON hit in ppp_pernet() when re-connect after changing shared key on LAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUEKrcuQvcXO_Rembgk_ZKc-v9Pe2ZEuZ5W_QxdcYDDNQ@mail.gmail.com>
Date:	Tue, 5 Jul 2016 13:36:53 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Matt Bennett <Matt.Bennett@...iedtelesis.co.nz>
Cc:	"linux-ppp@...r.kernel.org" <linux-ppp@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"g.nault@...halink.fr" <g.nault@...halink.fr>
Subject: Re: Problem: BUG_ON hit in ppp_pernet() when re-connect after
 changing shared key on LAC

On Tue, Jul 5, 2016 at 10:59 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Mon, Jul 4, 2016 at 7:50 PM, Matt Bennett
> <Matt.Bennett@...iedtelesis.co.nz> wrote:
>> Using printk I have confirmed that ppp_pernet() is called from
>> ppp_connect_channel() when the BUG occurs (i.e. pch->chan_net is NULL).
>>
>> This behavior appears to have been introduced in commit 1f461dc ("ppp:
>> take reference on channels netns").
>
> We have some race condition here, where a parallel ppp_unregister_channel()
> could happen while we are in ppp_connect_channel().
>
> We need some synchronization for them. I am not sure what is the right lock
> here since ppp locking looks crazy.

Matt, could you try if the attached patch helps?

Thanks!

View attachment "ppp.diff" of type "text/plain" (738 bytes)