netdev - Re: Re: [PATCH 00/11] pull request for net-next: batman-adv 2016-07-04

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 05 Jul 2016 11:02:05 +0200
From:	Simon Wunderlich <sw@...onwunderlich.de>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: Re: [PATCH 00/11] pull request for net-next: batman-adv 2016-07-04

Hi David,

On Monday 04 July 2016 23:37:25 David Miller wrote:
> From: Simon Wunderlich <sw@...onwunderlich.de>
> Date: Mon,  4 Jul 2016 15:02:48 +0200
> 
> > this is our second and final feature pull request for batman-adv in this
> > round.
> > 
> > Please pull or let me know of any problem!
> 
> Pulled, thanks.
> 
> I have no idea why you guys were using debugfs for anything that
> actually matters like configuration. :-/  debugfs should only be
> used for "debugging", such that if debugfs were not present the
> full functionality of the facility would still be present.

as Sven pointed out, debugfs was not used for configuration (except for very 
deep tune parameters which are really for debugging anyway). We use sysfs 
(formerly) and now rtnl for configuration.

However, debugfs has quite some tables showing the current state of the mesh 
(read only) which are obviously interesting for many users as well. Therefore 
we want to change to a netlink based interface in the long run, similar to 
what the wireless stack and iw are doing. This will also enable new features 
like proper namespace support, which we are going to integrate soon.

Cheers,
     Simon
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)