netdev - Re: [PATCH] xfrm: fix crash in XFRM_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <577B8874.5060904@6wind.com>
Date:	Tue, 5 Jul 2016 12:14:12 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Vegard Nossum <vegard.nossum@...cle.com>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

Le 05/07/2016 10:18, Vegard Nossum a écrit :
> If we hit any of the error conditions inside xfrm_dump_sa(), then
> xfrm_state_walk_init() never gets called. However, we still call
> xfrm_state_walk_done() from xfrm_dump_sa_done(), which will crash
> because the state walk was never initialized properly.
> 
> We can fix this by setting cb->args[0] only after we've processed the
> first element and checking this before calling xfrm_state_walk_done().
> 
> Fixes: d3623099d3 ("ipsec: add support of limited SA dump")
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Thank you for the fix!