netdev - Re: [patch net-next 01/16] net: add dev arg to ndo_neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160705120640.GB1984@nanopsycho.orion>
Date:	Tue, 5 Jul 2016 14:06:40 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"idosch@...lanox.com" <idosch@...lanox.com>,
	"yotamg@...lanox.com" <yotamg@...lanox.com>,
	"eladr@...lanox.com" <eladr@...lanox.com>,
	"nogahf@...lanox.com" <nogahf@...lanox.com>,
	"ogerlitz@...lanox.com" <ogerlitz@...lanox.com>,
	"sfeldma@...il.com" <sfeldma@...il.com>,
	"roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
	"andy@...yhouse.net" <andy@...yhouse.net>,
	"dsa@...ulusnetworks.com" <dsa@...ulusnetworks.com>,
	"tgraf@...g.ch" <tgraf@...g.ch>,
	"jhs@...atatu.com" <jhs@...atatu.com>,
	"linville@...driver.com" <linville@...driver.com>,
	"ivecera@...hat.com" <ivecera@...hat.com>
Subject: Re: [patch net-next 01/16] net: add dev arg to
 ndo_neigh_construct/destroy

Tue, Jul 05, 2016 at 01:04:09PM CEST, Yuval.Mintz@...gic.com wrote:
>> -	int			(*ndo_neigh_construct)(struct neighbour *n);
>> -	void			(*ndo_neigh_destroy)(struct neighbour *n);
>> +	int			(*ndo_neigh_construct)(struct net_device
>> *dev,
>> +						       struct neighbour *n);
>> +	void			(*ndo_neigh_destroy)(struct net_device *dev,
>> +						     struct neighbour *n);
>
>Perhaps leverage the fact you touch this and add a comment about this NDO?

Adding comment should be done in a separate patch. It is unrelated to
the change this patch does. Feel free to send a follow-up.