netdev - Re: [PATCH net-next] net: bridge: extend MLD/IGMP query stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160706143118.2de2394c@samsung9>
Date:	Wed, 6 Jul 2016 14:31:18 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nikolay Aleksandrov <razor@...ckwall.org>
Cc:	netdev@...r.kernel.org, linus.luessing@...3.blue,
	roopa@...ulusnetworks.com, bridge@...ts.linux-foundation.org,
	davem@...emloft.net,
	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next] net: bridge: extend MLD/IGMP query stats

On Wed,  6 Jul 2016 12:12:21 -0700
Nikolay Aleksandrov <razor@...ckwall.org> wrote:

> As was suggested this patch adds support for the different versions of MLD
> and IGMP query types. Since the user visible structure is still in net-next
> we can augment it instead of adding netlink attributes.
> The distinction between the different IGMP/MLD query types is done as
> suggested in Section 7.1, RFC 3376 [1] and Section 8.1, RFC 3810 [2] based
> on query payload size and code for IGMP. Since all IGMP packets go through
> multicast_rcv() and it uses ip_mc_check_igmp/ipv6_mc_check_mld we can be
> sure that at least the ip/ipv6 header can be directly used.
> 
> [1] https://tools.ietf.org/html/rfc3376#section-7
> [2] https://tools.ietf.org/html/rfc3810#section-8.1
> 
> Suggested-by: Linus Lüssing <linus.luessing@...3.blue>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Looks good to me.
Acked-by: Stephen Hemminger <stephen@...workplumber.org>