netdev - Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467794644.1273.17.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Wed, 06 Jul 2016 10:44:04 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	luto@...nel.org, mingo@...nel.org, linux-kernel@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.

On Wed, 2016-07-06 at 16:15 +0800, Ding Tianhong wrote:
> Hi Eric：
> 
> I had found out that the patch aaf92f(netfilter: conntrack: resched in
> nf_ct_iterate_cleanup) solve the problem, 
> this patch add cond_sched() in the nf_ct_iterate_cleanup() which will
> be called in the net notifier chain every time,
> and I revert this patch at kernel 4.7-rc4 , it will panic for soft
> lockup, so I am not sure whether our patch is need,
> it looks like if I disable the CONFIG for netfilter that would
> register the nf_ct_iterate_cleanup as notifier, the problem still be
> exist.

Well, I do not have conntrack on my kernels, and I can not reproduce the
issue.

So I am guessing other patches also solved a scalability issue, between
4.1 and 4.7

I am aware of something that David did for IPv4, but this might help as
well for IPv6.

commit fbd40ea0180a2d328c5adc61414dc8bab9335ce2
ipv4: Don't do expensive useless work during inetdev destroy.