netdev - Re: [PATCH] Removing lots of IS_ERR_VALUE abuses and compilation warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Jul 2016 17:45:53 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linuxppc-dev@...ts.ozlabs.org
Cc:	Arvind Yadav <arvind.yadav.cs@...il.com>, leoli@...escale.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Removing lots of IS_ERR_VALUE abuses and compilation warning.

On Thursday, July 7, 2016 8:42:16 PM CEST Arvind Yadav wrote:
>     Passing value in IS_ERR_VALUE() is wrong, as they
>     pass an 'int' into a function that takes an 'unsigned long'
>     argument. This happens to work because the type is sign-extended
>     on 64-bit architectures before it gets converted into an
>     unsigned type.
> 
>     Passing an 'unsigned short' or 'unsigned int'
>     argument into IS_ERR_VALUE() is guaranteed to be broken, as are
>     8-bit integers and types that are wider than 'unsigned long'.
> 
>     Any user will get compilation warning for that do not pass an
>     'unsigned long' argument.
> 
>     Commit '287980e49f; - This change is alreday fixes lots of other
>     worst abusers.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> 

Acked-by: Arnd Bergmann <arnd@...db.de>

just notice about your submission that the changelog is whitespace
damaged, you probably got the leading whitespace when you pasted
a git log into the commit.

	Arnd