[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 06 Jul 2016 22:10:59 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: simon.horman@...ronome.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH/RFC net-next 2/4] sit: support MPLS over IPv4
From: Simon Horman <simon.horman@...ronome.com>
Date: Wed, 6 Jul 2016 20:22:33 +0200
>
> +bool ipip6_valid_ip_proto(u8 ipproto)
> +{
> + return ipproto == IPPROTO_IPV6 ||
> + ipproto != IPPROTO_IPIP ||
> +#if IS_ENABLED(CONFIG_MPLS)
> + ipproto == IPPROTO_MPLS ||
> +#endif
> + ipproto == 0;
> +}
This returns true any time ipproto is not equal to IPPROTO_IPIP,
which is probably not what you intended here.
Powered by blists - more mailing lists