netdev - Re: [patch -next] bnxt: fix a condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 01:31:46 -0700
From:	Michael Chan <michael.chan@...adcom.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Jeffrey Huang <huangjw@...adcom.com>,
	Alexander Duyck <aduyck@...antis.com>,
	Netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] bnxt: fix a condition

On Thu, Jul 7, 2016 at 1:23 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> This code generates as static checker warning because htons(ETH_P_IPV6)
> is always true.  From the context it looks like the && was intended to
> be !=.
>
> Fixes: 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks.  The fix is correct.

Acked-by: Michael Chan <michael.chan@...adcom.com>